Prevent color name clash between swiftui and trikot.viewmodel #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens in projects currently migrating from Trikot.viewmodels when since the Color class ends up in the published framework
marcantoinefortier
approved these changes
Oct 25, 2023
marclefrancois
deleted the
fix/prevent-color-name-clash-between-swiftui-and-trikot.viewmodel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case where a trikot based project is currently migrating from
trikot.viewmodelstotrikot.viewmodel-declarativethere is a name clash inVMDHtmlText.swiftbetween SwiftUI.Color and TRIKOT_FRAMEWORK_NAME.ColorI also improved the look and feel of the sample in dark mode while at it.
Motivation and Context
To fix a blocking problem for projects that use both versions of the viewModel
How Has This Been Tested?
Ran the sample app
Types of changes