Add generic open datasources so that each project don't need their own #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npresseault
reviewed
Nov 30, 2023
...-flow/src/jsMain/kotlin/com/mirego/trikot/datasources/flow/filesystem/NativeFileSystem.js.kt
Outdated
Show resolved
Hide resolved
...s-flow/src/commonMain/kotlin/com/mirego/trikot/datasources/flow/generic/GenericDataSource.kt
Outdated
Show resolved
Hide resolved
...s-flow/src/commonMain/kotlin/com/mirego/trikot/datasources/flow/generic/GenericDataSource.kt
Outdated
Show resolved
Hide resolved
...ow/src/commonMain/kotlin/com/mirego/trikot/datasources/flow/generic/GenericDiskDataSource.kt
Outdated
Show resolved
Hide resolved
npresseault
reviewed
Dec 1, 2023
trikot-datasources/datasources-flow/api/jvm/datasources-flow.api
Outdated
Show resolved
Hide resolved
...datasources-flow/src/commonMain/kotlin/com/mirego/trikot/datasources/flow/DataSourceUtils.kt
Outdated
Show resolved
Hide resolved
npresseault
reviewed
Dec 1, 2023
...low/src/commonMain/kotlin/com/mirego/trikot/datasources/flow/generic/FileSystemDataSource.kt
Outdated
Show resolved
Hide resolved
npresseault
approved these changes
Dec 1, 2023
|
Tests would've been nice too! |
marcantoinefortier
approved these changes
Dec 1, 2023
|
I needed to put this in a separate module since @npresseault made me realize that okio does not support a Filesystem for browsers. This new module support android and native targets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every project I worked on had these generic classes. It is simpler if the open, generic classes that we want to overload come from the lib instead.
Motivation and Context
I wanted to stop copying the boilerplate from projet to project
How Has This Been Tested?
I took these classes from an existing project
Types of changes