Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create footer #958

Merged
merged 9 commits into from
Nov 28, 2024
Merged

docs: create footer #958

merged 9 commits into from
Nov 28, 2024

Conversation

mariejuenke
Copy link
Contributor

closes #904

@mariejuenke mariejuenke marked this pull request as draft November 7, 2024 16:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 28.84% 4281 / 14840
🔵 Statements 28.84% 4281 / 14840
🔵 Functions 32.7% 227 / 694
🔵 Branches 56.25% 486 / 864
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/ColumnLayout/ColumnLayout.tsx 0% 0% 0% 0% 1-74
packages/components/src/components/Section/Section.tsx 18.36% 100% 100% 18.36% 21-67
Generated in workflow #1796 for commit 1e094b9 by the Vitest Coverage Report Action

@mariejuenke mariejuenke temporarily deployed to github-pages-preview-storybook November 21, 2024 09:32 — with GitHub Actions Inactive
@mariejuenke mariejuenke temporarily deployed to github-pages-preview-storybook November 21, 2024 09:38 — with GitHub Actions Inactive
@mariejuenke mariejuenke marked this pull request as ready for review November 21, 2024 09:53
@mfal mfal removed their request for review November 22, 2024 07:31
@mfal mfal merged commit ee0fadb into main Nov 28, 2024
4 checks passed
@mfal mfal deleted the docs/createFooter branch November 28, 2024 22:21
@thueske
Copy link
Member

thueske commented Nov 29, 2024

The footer is not implemented as in the concept (logo positioning). The scrollable area is also too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfal mfal mfal approved these changes

@Lisa18289 Lisa18289 Awaiting requested review from Lisa18289

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a Footer
3 participants
@mariejuenke @thueske @mfal