Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LightBox): add LightBox component #972

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat(LightBox): add LightBox component #972

merged 3 commits into from
Nov 18, 2024

Conversation

Lisa18289
Copy link
Member

@Lisa18289 Lisa18289 commented Nov 14, 2024

Documentation

Description

With the Lightbox component, we want to enable users of our design system to open images or PDFs in full size within the same tab.

Design

The Lightbox consists of a backdrop that is significantly darker than that of a modal, allowing the image or PDF to stand out more prominently. It includes an Action Group, which allows developers to add additional actions. A close button is always present. This Action Group can be supplemented with further options, such as Download or Print. Due to the dark background, the Light-Soft variant was chosen for the buttons. The image should always occupy 90% of the viewport, with the buttons positioned to the right of the image.

Lightbox

Token

--lightbox-color: var(--color-dark-color-600);
--lightbox-spacing: var(--size-m);

@Lisa18289 Lisa18289 self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 29.28% 4242 / 14485
🔵 Statements 29.28% 4242 / 14485
🔵 Functions 32.99% 226 / 685
🔵 Branches 56.74% 484 / 853
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/vite.build.config.base.ts 0% 0% 0% 0% 1-142
packages/components/src/components/LightBox/LightBox.tsx 0% 0% 0% 0% 1-76
packages/components/src/components/LightBox/index.ts 0% 0% 0% 0% 1-5
packages/components/src/components/LightBox/components/LightBoxTrigger/LightBoxTrigger.tsx 0% 0% 0% 0% 1-18
packages/components/src/components/LightBox/components/LightBoxTrigger/index.ts 0% 0% 0% 0% 1-4
packages/components/src/components/LightBox/stories/Default.stories.tsx 0% 0% 0% 0% 1-42
packages/components/src/components/Modal/Modal.tsx 88.57% 33.33% 100% 88.57% 77-85
packages/components/src/components/Overlay/index.ts 100% 100% 100% 100%
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
Generated in workflow #1764 for commit 3c964c1 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook November 18, 2024 06:46 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview November 18, 2024 06:46 — with GitHub Actions Inactive
packages/design-tokens/src/overlays/light-box.yml Outdated Show resolved Hide resolved
packages/design-tokens/src/overlays/light-box.yml Outdated Show resolved Hide resolved
@mfal mfal merged commit b648941 into main Nov 18, 2024
4 checks passed
@mfal mfal deleted the add-lightbox-component branch November 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants