Fix concurrent map access by using a synchronized map #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone please have a look? It should be very easy to verify that this PR fixes the concurrent map access in the generic_replicator. |
|
@Lucaber Could you perhaps have a look? I saw you recently approved and merged a PR in this repo. Many thanks! |
martin-helmich
approved these changes
Sep 11, 2024
daniel-ciaglia
added a commit
to lynqtech/kubernetes-replicator
that referenced
this pull request
Sep 16, 2024
* introduce generic synced map, use in generic_iterator (mittwald#348) * Bump go to 1.22 (mittwald#343) Co-authored-by: JorgeQ <[email protected]> Co-authored-by: Martin Helmich <[email protected]> * Bump chartVersion and appVersion to 'v2.10.2' --------- Co-authored-by: Stephan Aßmus <[email protected]> Co-authored-by: JorgeAndresQuintero <[email protected]> Co-authored-by: JorgeQ <[email protected]> Co-authored-by: Martin Helmich <[email protected]> Co-authored-by: Mittwald Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
Copy'ing the analysis from the issue here:
generic_replicatoruses it to register hook functions to be informed on namespace additions and updates.generic_replicatoralso uses its own informer to be notified of changes to other resources.NamespaceAddedhook as well as written from theResourceAddedhook called by the other Informer.We switched to using a
sync.MapforReplicateToListandReplicateToMatchingList.We did not change the
DependencyMap, since it is only used in the resources informer hooks.We also created a simple test to see whether there is any noticeable change to the performance:
fake.NewClientset()K8s clientWe did not see any change in the execution time. But of course this test may not be extensive, so any insights are appreciated.