Fixed StaticVectorPointerTest on neon64 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roversch
approved these changes
Nov 7, 2024
| /** | ||
| * @brief Row view of a matrix | ||
| * | ||
| * NOTE: this implementation is not optimized! |
There was a problem hiding this comment.
Please tell us what can be improved still.
mkatliar
force-pushed
the
neon64_static_vector_pointer_test_fix
branch
from
a2e52ca to
86b1607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing with
"Pointer is not aligned"assertion error. This is because theStaticVectorclass from Blaze was used, which does not allocate aligned memory for vectors onneon64. This got fixed by introducing theblast::StaticVectorclass which allocates a properly aligned memory chunk for its data.