Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_reference_implicit_with_code_inlinehilite_python #60

Closed
wants to merge 2 commits into from

Conversation

davide125
Copy link

Fix the test with the latest pymdownx

@davide125
Copy link
Author

Ah if this needs to support multiple versions we might have to somehow make it conditional

@pawamoy
Copy link
Member

pawamoy commented Dec 13, 2024

Thanks! We can simply dev-depend on a recent enough pymdownx version 🙂 Asserting the output in our own tests suite shouldn't affect actual features or users, which can use older pymdownx versions. But please wait a bit before working on this: I have a few unpushed commits that are touching to both pyproject.toml and the tests suite.

@pawamoy
Copy link
Member

pawamoy commented Jan 10, 2025

We install the latest version of pymdown-extensions but the test fails, am I missing something?

@pawamoy
Copy link
Member

pawamoy commented Jan 10, 2025

IIUC the language class is only added if pygments_lang_class is set to true in pymdownx.highlight's config, which isn't the case here. Closing for now, we can reopen if I got something wrong 🙂

@pawamoy pawamoy closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants