Fix image list mismatch #1579
Merged
Fix image list mismatch #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Thank you @pgmpablo157321 for the fix. Should we also add captions.txt to the expected files list in the submission checker? |
pgmpablo157321
force-pushed
the
sd_fix
branch
3 times, most recently
from
5db0a3f to
bec8218
Compare
pgmpablo157321
force-pushed
the
sd_fix
branch
from
bec8218 to
7bc5afe
Compare
arjunsuresh
reviewed
Jan 25, 2024
| @@ -1785,6 +1785,8 @@ def check_extra_files(path, target_files): | |||
| if target_file not in files: | |||
| check_pass = False | |||
| missing_files.append(f"{os.path.join(path, dir, target_file)}.png") | |||
| if "captions" not in files: | |||
There was a problem hiding this comment.
Should this be "captions.txt" ?
There was a problem hiding this comment.
I am currently ignoring the file extensions and removing them from the filenames. So that you can send a .png or .jpg. So the files array would only contain .../captions
mrmhodak
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1575