Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including version information in the database. This file reads the config.yaml file and returns a dictionary which contains library as the key and version as the value. #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Iron-Stark
Copy link
Contributor

@Iron-Stark Iron-Stark commented Apr 6, 2017

@rcurtin @zoq

This is regarding Issue (#42). I need some pointers on which piece of code to look for if I want to include the information returned by the dictionary in the database.

zoq and others added 2 commits April 6, 2017 19:29
Added more options like min_samples_split,min_samples_leaf,max_features and max_nodes in Decision Tree scikit implementation.
@mlpack-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@rcurtin
Copy link
Member

rcurtin commented Jun 8, 2017

Hi @Iron-Stark, sorry for the slow reply on this one. I think that what we should do instead is get the version information from libraries/package-urls.txt (we probably have to add a new column), that way when you update the package you only have to do it in one place.

All of the database code is found in util/database.py, so I think the majority of modification would go there.

From there I think there are a couple options; not sure what you think is best (@zoq, you probably have an opinion too, feel free to elaborate):

  • Change the name for the libraries table to include the version, i.e. library_name + " " + version --> mlpack 2.2.3. Probably no other modification necessary, one would just need to update all the code that generates library names in the code.

  • Add a version field to the libraries table (see CreateLibrariesTable()), then make sure that the version is properly handled when adding new benchmark results in NewMetricResult(), NewBootstrapResult(), UpdateMetricResult(), UpdateMetricResult(), NewResult(), and UpdateResult(), and possibly other places (I haven't done a full search).

What do you think? There are probably other ideas too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants