Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update containerd binary to v1.7.7 #4339

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah
Copy link
Member Author

Wondering what these failures are;

Dockerfile:75
--------------------
  74 |       [ "$(xx-info arch)" != "ppc64le" ] || XX_CC_PREFER_LINKER=ld xx-clang --setup-target-triple
  75 | >>> RUN --mount=from=runc-src,src=/usr/src/runc,target=. --mount=target=/root/.cache,type=cache \
  76 | >>>   CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo' -o /usr/bin/runc ./ && \
  77 | >>>   xx-verify --static /usr/bin/runc
  78 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo' -o /usr/bin/runc ./ &&   xx-verify --static /usr/bin/runc" did not complete successfully: exit code: 1
Error: Process completed with exit code 1.

Are those related to runc no longer being static on MUSL / alpine? @crazy-max

@crazy-max
Copy link
Member

crazy-max commented Oct 16, 2023

Wondering what these failures are;

Dockerfile:75
--------------------
  74 |       [ "$(xx-info arch)" != "ppc64le" ] || XX_CC_PREFER_LINKER=ld xx-clang --setup-target-triple
  75 | >>> RUN --mount=from=runc-src,src=/usr/src/runc,target=. --mount=target=/root/.cache,type=cache \
  76 | >>>   CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo' -o /usr/bin/runc ./ && \
  77 | >>>   xx-verify --static /usr/bin/runc
  78 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo' -o /usr/bin/runc ./ &&   xx-verify --static /usr/bin/runc" did not complete successfully: exit code: 1
Error: Process completed with exit code 1.

Are those related to runc no longer being static on MUSL / alpine? @crazy-max

* [Build does not produce statically linked binary anymore (on musl hosts) opencontainers/runc#3950](https://github.com/opencontainers/runc/issues/3950)

#4316

Workaround with glibc #4332

@crazy-max crazy-max merged commit 41fec4f into moby:master Oct 16, 2023
53 of 56 checks passed
@thaJeztah
Copy link
Member Author

Oh! Thanks! I thought it was a separate issue from the riscv one, but it's the same then 👍

@thaJeztah thaJeztah deleted the update_containerd_binary_1.7.7 branch October 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants