Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contracts for Layout and Alignment #33

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tautschnig
Copy link
Member

These contracts seek to capture what is described in documentation and debug assertions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@tautschnig tautschnig self-assigned this Jul 9, 2024
@celinval celinval self-requested a review July 9, 2024 18:54
library/core/src/alloc/layout.rs Outdated Show resolved Hide resolved
library/core/src/alloc/layout.rs Outdated Show resolved Hide resolved
@tautschnig tautschnig marked this pull request as ready for review July 10, 2024 15:11
@tautschnig tautschnig requested a review from a team as a code owner July 10, 2024 15:11
jaisnan

This comment was marked as duplicate.

@tautschnig tautschnig assigned celinval and unassigned tautschnig Jul 10, 2024
@jaisnan jaisnan dismissed their stale review July 10, 2024 18:30

Re-triggering the approval flow

jaisnan

This comment was marked as duplicate.

These contracts seek to capture what is described in documentation and
debug assertions.
@jaisnan jaisnan dismissed their stale review July 10, 2024 18:51

Re-triggering the approval flow

Copy link

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

library/core/src/ptr/alignment.rs Show resolved Hide resolved
@tautschnig tautschnig merged commit fd1c9c2 into model-checking:main Jul 11, 2024
9 of 10 checks passed
@tautschnig tautschnig deleted the layout-contracts branch July 11, 2024 21:13
tautschnig added a commit to tautschnig/verify-rust-std that referenced this pull request Jul 23, 2024
In model-checking#33 a contract was added to `Alignment::new_unchecked`, but its
verification was only implicit through `Layout`, and may be affected by
future changes to the contract that was added to `Layout`. This commit
remedies this by adding a separate harness just for `Alignment`.
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
These contracts seek to capture what is described in documentation and
debug assertions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants