Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Types Challenge #82

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

carolynzech
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
Copy link

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carolynzech! Is there any usage of the unsafe functions in the standard library that is worth including in the challenge?

doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
@carolynzech
Copy link
Author

carolynzech commented Sep 13, 2024

Thanks @carolynzech! Is there any usage of the unsafe functions in the standard library that is worth including in the challenge?

Yes. I was erring on the side of keeping this challenge smaller, but there's some libraries that use more of the methods than ReentrantLock does. I'll add a section.
The one module that really takes advantage of these methods is MPMC. We should make a separate challenge to verify this one at some point.

@carolynzech carolynzech marked this pull request as draft September 19, 2024 14:28
@carolynzech carolynzech marked this pull request as ready for review September 19, 2024 20:42
Copy link

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carolynzech

I just have a few suggestions about the wording.

doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
@feliperodri feliperodri added the Challenge Used to tag a challenge label Oct 8, 2024
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
doc/src/challenges/0007-atomic-types.md Outdated Show resolved Hide resolved
@feliperodri feliperodri enabled auto-merge (squash) October 30, 2024 17:04
@feliperodri feliperodri merged commit 977cf8b into model-checking:main Oct 30, 2024
9 checks passed
@carolynzech carolynzech deleted the atomic-challenge branch October 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenge Used to tag a challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants