-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: serve on ipv4 #196
fix: serve on ipv4 #196
Conversation
Hi ! |
Tests are working fine on the main branch |
98d6576
to
cf7c4ac
Compare
Hi @gioboa |
cf7c4ac
to
0eea33a
Compare
Hi @gioboa |
It looks great to me, why we are doing a special check for |
Hi @gioboa
In IPv4, the address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nicotu01 for your help and your exhaustive explanation
Kudos for your first PR in this project 👏
Fix #194