feat: new functions added + arguments to class instance

monerium · Nov 9, 2023 · b5b8c5d · b5b8c5d
1 parent ac8553f
commit b5b8c5d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -26,20 +26,18 @@ jobs:
         uses: actions/checkout@v3
         # these if statements ensure that a publication only occurs when
         # a new release is created:
-        # if: ${{ steps.release.outputs.releases_created }}
+        if: ${{ steps.release.outputs.releases_created }}
       - name: Derive appropriate SHAs for base and head for `nx affected` commands
         uses: nrwl/nx-set-shas@v3
-        with:
-          main-branch-name: "main"
       - name: Yarn install
         run: yarn install --immutable --immutable-cache
         # for security reasons, use --check-cache if accepting PRs from third-parties.
-        # if: ${{ steps.release.outputs.releases_created }}
-      - run: echo "Release ${{ steps.release.outputs['packages/sdk--tag_name'] }} created for sdk."
-        if: ${{ steps.release.outputs['packages/sdk--release_created'] }}
+        if: ${{ steps.release.outputs.releases_created }}
+      - run: echo "Release ${{ steps.release.outputs['libs/sdk--tag_name'] }} created for sdk."
+        if: ${{ steps.release.outputs['libs/sdk--release_created'] }}
       # Conditionally publish packages based on changes in their respective dist directories
       - name: Publish NPM package ${{ steps.release.outputs.tag_name }}
-        run: yarn nx affected -t lint --base=${{ env.NX_BASE }} --head=${{ env.NX_HEAD }}
+        run: yarn nx affected -t publish --base=${{ env.NX_BASE }} --head=${{ env.NX_HEAD }}
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
         if: ${{ steps.release.outputs.releases_created }}

diff --git a/libs/sdk/project.json b/libs/sdk/project.json
@@ -12,14 +12,18 @@
       }
     },
     "prepublish": {
-      "command": "echo",
-      "dependsOn": ["build", "test", "lint"]
+      "dependsOn": ["build", "test", "lint"],
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npm pack --dry-run",
+        "cwd": "libs/sdk"
+      }
     },
     "publish": {
       "dependsOn": ["prepublish"],
       "executor": "nx:run-commands",
       "options": {
-        "command": "npm pack --dry-run",
+        "command": "npm publish --access public",
         "cwd": "libs/sdk"
       }
     },

diff --git a/libs/sdk/src/client.ts b/libs/sdk/src/client.ts
@@ -98,6 +98,7 @@ export class MoneriumClient {
       }
     }
   }
+
   /**
    * Construct the url to the authorization code flow,
    * Code Verifier needed for the code challenge is stored in session storage
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,6 +98,7 @@ export class MoneriumClient { @@
           }
         }
       }
       /**
        * Construct the url to the authorization code flow,
        * Code Verifier needed for the code challenge is stored in session storage
@@ Expand Down @@