Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.11 Release #60

Merged

Conversation

jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented Oct 2, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44051
Staging -
https://deploy-preview-60--docs-cpp.netlify.app/
https://deploy-preview-60--docs-cpp.netlify.app/whats-new/
https://deploy-preview-60--docs-cpp.netlify.app/upgrade/#version-3.11-breaking-changes

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for docs-cpp ready!

Name Link
🔨 Latest commit 9633f4b
🔍 Latest deploy log https://app.netlify.com/sites/docs-cpp/deploys/66fff3008cd2140008c1cff1
😎 Deploy Preview https://deploy-preview-60--docs-cpp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ a couple notes

more information about Queryable Encryption, see :manual:`Queryable
Encryption </core/queryable-encryption>` in the {+mdb-server+} manual.
- Adds ``empty()`` member function for ``mongocxx::v_noabi::bulk_write``.
- The minimum C driver version is now 1.28.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The minimum C driver version is now 1.28.0
- The minimum C driver version is now 1.28.0.

Version 3.11 Breaking Changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- Drops support for {+mdb-server+} v3.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Drops support for {+mdb-server+} v3.6
- Drops support for {+mdb-server+} v3.6.

source/whats-new.txt Show resolved Hide resolved
source/whats-new.txt Outdated Show resolved Hide resolved
source/upgrade.txt Show resolved Hide resolved
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments addressed.

What's New in 3.11
------------------

.. warning:: Build System Breaking Changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. warning:: Build System Breaking Changes
.. warning:: Breaking Changes

Comment on lines 115 to 118
- Dependencies are populated by using the ``FetchContent_MakeAvailable()``
function instead of ``FetchContent_Populate()``.
- The test suite now uses Catch2 v3 by using ``FetchContent()`` instead of the
bundled Catch2 v2 standalone header.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Dependencies are populated by using the ``FetchContent_MakeAvailable()``
function instead of ``FetchContent_Populate()``.
- The test suite now uses Catch2 v3 by using ``FetchContent()`` instead of the
bundled Catch2 v2 standalone header.

Consider removing these points, or putting in a separate list:

The v3.11 driver release includes the following changes:

- Dependencies are populated by using the ``FetchContent_MakeAvailable()``
  function instead of ``FetchContent_Populate()``.
- The test suite now uses Catch2 v3 by using ``FetchContent()`` instead of the
  bundled Catch2 v2 standalone header.

I do not consider these new features (implementation/test changes). They may not be relevant for a "What's New" page.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as it's not as relevant. We also link to the release notes here so users will still be able to find it

@jordan-smith721 jordan-smith721 merged commit d2c85e9 into mongodb:master Oct 4, 2024
5 checks passed
@jordan-smith721 jordan-smith721 deleted the DOCSP-44051-3.11-release branch October 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants