-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39838) [CPP Driver] Write Data to MongoDB > Replace a Document #62
Conversation
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this page! I left some suggestions/comments, mostly small ones
910be08
to
a42843c
Compare
8fc44c6
to
5e17408
Compare
0b61875
to
c1fa4ba
Compare
…nd replaced link for hint field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just a few more things!
49f4063
to
27f0a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple small suggestions - great job!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor non-public-facing comment fix.
…mongodb#62) * (DOCSP-49838) New pages for replace_one * (DOCSP-39838) Build error. * (DOCSP-39838) Edited write landing page to include replace page. * (DOCSP-39838) Reordered options and results tables. * (DOCSP-39838) Hint example. * (DOCSP-39838) Build error fix. * (DOCSP-39838) Adding separate section level for examples. * (DOCSP-39838) Levels. * (DOCSP-39838) Edits. * (DOCSP-39838) Example edit. * (DOCSP-39838) Edits. * (DOCSP-39838) Updated the Write Data landing page to have replace code example. * (DOCSP-39838) Updated the Write Data landing page code sample * (DOCSP-39838) Updated the Write Data landing page code sample (added comment) * (DOCSP-39838) Changes. * (DOCSP-39838) Edit landing page code example. * (DOCSP-39838) Include _id field mention in first paragraph. * (DOCSP-39838) Edits. * (DOCP-39838) Update links in table. * (DOCSP-39838) edits. * (DOCSP-39838) Added important admonition. * (DOCSP-39838) Edits * (DOCSP-39838) Edits * (DOCSP-39838) Edit table header. * (DOCSP-39838) Added comments to example. * (DOCSP-39838) Indentation error. * (DOCSP-39838) Table edits. * (DOCSP-39838) Separated output from example. * (DOCSP-39838) Example wording. * (DOCSP-39838) Render error * (DOCSP-39838) Example rendering fixes. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Indent error * (DOCSP-39838) Indent error * (DOCSP-39838) Adding quotation marks to field values. * (DOCSP-39838) @norareidy removed inline find_one() link. * (DOCSP-39838) @norareidy Replace update with replace. * (DOCSP-39838) @norareidy removed monospace from headers for style guide. * (DOCSP-39838) @norareidy Swapping field and function. * (DOCSP-39838) @norareidy Condensing example introduction. * (DOCSP-39838) @norareidy Condensing example introduction. * (DOCSP-39838) @norareidy Condensing and wording edits for example introductions. * (DOCSP-39838) @norareidy Adding warning that sample ID may differ. * (DOCSP-39838) @norareidy Bolded first instance of replace operation and replaced link for hint field. * (DOCSP-39838) @norareidy Header underline fix. * (DOCSP-39838) Adding context to links. * (DOCSP-39838) @norareidy review edits. * (DOCSP-39838) @norareidy Final review changes. * (DOCSP-39838) @kevinAlbs comment fixes. --------- Co-authored-by: Elyse Foreman <[email protected]>
…#62) (#65) * (DOCSP-49838) New pages for replace_one * (DOCSP-39838) Build error. * (DOCSP-39838) Edited write landing page to include replace page. * (DOCSP-39838) Reordered options and results tables. * (DOCSP-39838) Hint example. * (DOCSP-39838) Build error fix. * (DOCSP-39838) Adding separate section level for examples. * (DOCSP-39838) Levels. * (DOCSP-39838) Edits. * (DOCSP-39838) Example edit. * (DOCSP-39838) Edits. * (DOCSP-39838) Updated the Write Data landing page to have replace code example. * (DOCSP-39838) Updated the Write Data landing page code sample * (DOCSP-39838) Updated the Write Data landing page code sample (added comment) * (DOCSP-39838) Changes. * (DOCSP-39838) Edit landing page code example. * (DOCSP-39838) Include _id field mention in first paragraph. * (DOCSP-39838) Edits. * (DOCP-39838) Update links in table. * (DOCSP-39838) edits. * (DOCSP-39838) Added important admonition. * (DOCSP-39838) Edits * (DOCSP-39838) Edits * (DOCSP-39838) Edit table header. * (DOCSP-39838) Added comments to example. * (DOCSP-39838) Indentation error. * (DOCSP-39838) Table edits. * (DOCSP-39838) Separated output from example. * (DOCSP-39838) Example wording. * (DOCSP-39838) Render error * (DOCSP-39838) Example rendering fixes. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Misc edits. * (DOCSP-39838) Indent error * (DOCSP-39838) Indent error * (DOCSP-39838) Adding quotation marks to field values. * (DOCSP-39838) @norareidy removed inline find_one() link. * (DOCSP-39838) @norareidy Replace update with replace. * (DOCSP-39838) @norareidy removed monospace from headers for style guide. * (DOCSP-39838) @norareidy Swapping field and function. * (DOCSP-39838) @norareidy Condensing example introduction. * (DOCSP-39838) @norareidy Condensing example introduction. * (DOCSP-39838) @norareidy Condensing and wording edits for example introductions. * (DOCSP-39838) @norareidy Adding warning that sample ID may differ. * (DOCSP-39838) @norareidy Bolded first instance of replace operation and replaced link for hint field. * (DOCSP-39838) @norareidy Header underline fix. * (DOCSP-39838) Adding context to links. * (DOCSP-39838) @norareidy review edits. * (DOCSP-39838) @norareidy Final review changes. * (DOCSP-39838) @kevinAlbs comment fixes. ---------
Pull Request Info
Added a new page documenting the replace_one() method.
PR Reviewing Guidelines
JIRA - DOCSP-39838
Staging -
Self-Review Checklist