-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-1318: Remove prop-types from LeafyGreen #2619
Conversation
🦋 Changeset detectedLatest commit: 22e0b8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 89 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: -34.2 kB (-2.44%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Beautiful ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for working through this :D
had a few comments/questions not included in this PR:
- I think we should also remove the
eslint-disable*
comments mentioningreact/prop-types
in stories / spec files - do we still need the
propTypes
prop in box, polymorphic, and table? - I think we should also remove the
scripts/proptypes.ts
script
@@ -0,0 +1,60 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still working through pnpm but would be curious to discuss with team on pros/cons of batching those changes with this removal or the alternative of keeping them separate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
✍️ Proposed changes
🎟 Jira ticket: LG-1318
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes