Verify oracle availability using "DATABASE IS READY TO USE!" #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have ensured that all the oracle database images output at the end of the init script the "DATABASE IS READY TO USE!" text. That has been done by: moodlehq/moodle-db-oracle#13 (Because Oracle 11g was missing that string) So, now that the string is available in all moodle-db-oracle images we can start using it here, in moodle-docker. Still note this is not the ideal wait/health-check system and we'll have to move to a proper one. See: moodlehq#160 But it's better than nothing, and the current one based on the "Database opened." string was not working ok for Oracle 21c (that requires 2 startups).
|
If automated tests for the master branch with Oracle now pass... it means the detection of the new string is working as expected. Before this PR those jobs were failing 50% of time, assuming that the database was ready too early. Ciao :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have ensured that all the oracle database images output
at the end of the init script the "DATABASE IS READY TO USE!"
text. That has been done by:
moodlehq/moodle-db-oracle#13
(Because Oracle 11g was missing that string)
So, now that the string is available in all moodle-db-oracle
images we can start using it here, in moodle-docker.
Still note this is not the ideal wait/health-check system
and we'll have to move to a proper one. See:
#160
But it's better than nothing, and the current one based
on the "Database opened." string was not working ok for
Oracle 21c (that requires 2 startups).