-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Better quotations #349
Open
keddelzz
wants to merge
11
commits into
master
Choose a base branch
from
splicing-and-unsplicing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dd266c9
Implement quotation macro from scratch
keddelzz 29f291d
Reimplement unquoting and implement unsplicing (#345)
keddelzz 61dbcb1
Add test for new marker (dotted holes) (#345)
keddelzz f519f69
Add tests for splicing/unsplicing terms in/from lists (#345)
keddelzz 6018ad2
Fix creating expression in pattern position (#345)
keddelzz 192b9ed
Fix splicing of sequences (other than lists) not working (#345)
keddelzz 2c4934b
Add tests for unsplicing and autoconversion during unlifing (#345)
keddelzz 5280f96
Make 'sequence'-function generic (#345)
keddelzz 0743525
Make 'UnapplyEach' work with every TraversableOnce (#345)
keddelzz 472fb9f
Unsplicing with autoconversion to annotated types (#345)
keddelzz ebc3942
Don't slay the compiler (#345)
keddelzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 13 additions & 4 deletions
17
kernel/src/main/scala/me/rexim/morganey/monad/package.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
macros/src/main/scala/me/rexim/morganey/meta/DottedHole.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package me.rexim.morganey.meta | ||
|
||
private[meta] object DottedHole { | ||
|
||
def unapply(arg: String): Option[Int] = | ||
if (arg startsWith "..") Hole.unapply(arg stripPrefix "..") | ||
else None | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it demands some additional tests. I understand the intention here to make it generic, but the implementation is too hard for me 😿