Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin #1166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Admin #1166

wants to merge 1 commit into from

Conversation

Pyifan
Copy link
Contributor

@Pyifan Pyifan commented Jan 3, 2025

Bug / Requirement Description

Clearly and concisely describe the problem.

Solution description

Describe your code changes in detail for reviewers.

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@Pyifan Pyifan requested a review from a team as a code owner January 3, 2025 10:53
if (this.state.aborting) {
this.setError({ message: "Server is aborting ..." });
return;
}
if (this.props.match.params.uid === "_dev") {
setTimeout(() => this.setReport(FakeInteractiveReport), 1500);
} else {
const url = firstGet
? "/api/v1/interactive/report?full=true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use {params: {full: true}} in axios

@@ -127,8 +127,9 @@ class Report(flask_restx.Resource):

def get(self):
"""Get the state of the root interactive report."""
full = flask.request.args.get("full", "false").lower() == "true"
Copy link
Contributor

@yuxuan-ms yuxuan-ms Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full = bool(flask.request.args.get("full", "false")) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants