Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is dd done? #7

Open
wants to merge 9 commits into
base: old
Choose a base branch
from
Open

Is dd done? #7

wants to merge 9 commits into from

Conversation

mortdeus
Copy link
Owner

If so I will merge your tree into my old branch, and then pull out dd into the dev branch. If its feature complete then I will go ahead and merge it into master branch with all the other v1.0 tools.

Sound good?

@kutani
Copy link
Contributor

kutani commented Mar 4, 2015

Ah hell, sorry, I've been way incommunicado lately. dd is largely complete, though it still needs testing, and the conversion mode stuff needs finishing. I just pushed my most recent (for old values of recent) changes to github.

I wouldn't feel comfortable putting it in a main branch until it's had a lot more testing, so definitely a dev branch deal. I remember hitting a number of edge cases where the output wasn't quite right. TBH it's been so long since I touched it that I can't remember if I solved them or not.

@mortdeus
Copy link
Owner Author

mortdeus commented Mar 9, 2015

Ill go ahead and take a look at it.

Also when it comes to the master branch, all tools that get pulled into master are tools that are deemed feature complete and for the most part shouldnt ever introduce changes that break legacy code. Of course some bugs might escape us into master branch, but any code that is codependent on the buggy functionality (e.g lexers/parsers that are designed to accept junk stdout/stderr formats) won't be protected from breakage.

Considering this policy, it is encouraged to work, push, and merge inside the dev branch.

I'll go ahead and make sure that all of these policies are added to the wiki.

On a final note, I thank you for your contribution to Goblin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants