Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete already closed client on closeSameClients #929

Merged
merged 4 commits into from
Jan 12, 2024
Merged

fix: delete already closed client on closeSameClients #929

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97a1f0b
delete already closed client on closeSameClients
Gianluca-Casagrande-Stiga Jan 8, 2024
a7e03ba
version rollback
Gianluca-Casagrande-Stiga Jan 9, 2024
644ce71
add clear closed clients test
Gianluca-Casagrande-Stiga Jan 9, 2024
2b56a3f
Merge branch 'main' into bugfix/closed-client
robertsLando Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion aedes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,13 @@ function Aedes (opts) {
const clientId = packet.payload.toString()

if (that.clients[clientId] && serverId !== that.id) {
that.clients[clientId].close(done)
if (that.clients[clientId].closed) {
// remove the client from the list if it is already closed
delete that.clients[clientId]
done()
} else {
that.clients[clientId].close(done)
}
} else {
done()
}
Expand Down