Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOSIP-25201 - Fix accessibility and SonarQube reliability issues in multiple components #198

Merged
merged 1 commit into from
Nov 25, 2024
Merged

MOSIP-25201 - Fix accessibility and SonarQube reliability issues in multiple components #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pre-registration-ui/src/app/feature/booking/time-selection/time-selection.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
selectedCard !== undefined
"
>
<table class="time-selection__name-list" aria-describedby="time-selection-name-list">
<table class="time-selection__name-list" aria-describedby="time-selection-name-list" role="presentation">
<tr
class="time-selection__name-list-item"
*ngFor="
Expand All @@ -202,7 +202,7 @@
>
<td>{{ item.fullName }}</td>
<td>
<mat-icon (click)="itemDelete(j)" class="name-delete-button"
<mat-icon (click)="itemDelete(j)" role="button" [tabIndex]="j" class="name-delete-button"
>close</mat-icon
>
</td>
Expand All @@ -216,7 +216,7 @@
{{ "timeSelection.text_available" | translate }}
</div>
<div>
<table class="time-selection__name-list" aria-describedby="time-selection-name-list">
<table class="time-selection__name-list" aria-describedby="time-selection-name-list" role="presentation">
<tr
class="time-selection__name-list-item"
*ngFor="let item of deletedNames; let k = index"
Expand All @@ -225,6 +225,8 @@
<td>
<mat-icon
(click)="addItem(k)"
role="button"
[tabindex]="k"
[ngClass]="
disableAddButton
? 'name-delete-button disable_add'
Expand Down
6 changes: 6 additions & 0 deletions pre-registration-ui/src/app/feature/dashboard/dashboard/dashboard.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@
<div class="card-content">
<table>
<caption>{{'dashboard.name' | translate}}</caption>
<thead>
<tr style="display: none">
<th class="column1">name</th>
<th class="application-value">value</th>
</tr>
</thead>
<tr>
<td class="column1">{{ "dashboard.card.text_name" | translate }}</td>
<td
Expand Down
12 changes: 9 additions & 3 deletions pre-registration-ui/src/app/feature/summary/acknowledgement/acknowledgement.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
<div class="ack__header-container" [dir]="ackData.appLangCodeDir">
<table>
<caption>{{'quick_guide.Acknowledgement.tablename' | translate}}</caption>
<thead>
<tr style="display: none">
<th>label</th>
<th>value</th>
</tr>
</thead>
<tr>
<td>{{ ackData.preRegIdLabels}} : </td>
<td><strong>{{ ackData.preRegId}}</strong></td>
Expand Down Expand Up @@ -58,7 +64,7 @@
</div>
<div [dir]="ackData.appLangCodeDir">
<div id="body-container" *ngIf="ackData.regCntrNames" class="ack__body-container">
<table id="table-container" aria-describedby="acknowledgement-data">
<table id="table-container" aria-describedby="acknowledgement-data" role="presentation">
<tr *ngIf="ackData.nameValues.trim() != ''">
<td>{{ ackData.labelNames }} : </td>
<td><strong>{{ ackData.nameValues }}</strong></td>
Expand All @@ -73,7 +79,7 @@
<div id="guidelines-container" class="ack__guidelines-container" [dir]="ackData.appLangCodeDir">
<span *ngFor="let langCode of ackData.appLangCode">
<div class="spacer"></div>
<table *ngIf="guidelines.length !== 0" class="ack__guidelines" aria-describedby="acknowledgement-guideline">
<table *ngIf="guidelines.length !== 0" class="ack__guidelines" aria-describedby="acknowledgement-guideline" role="presentation">
<tr *ngFor="let guideline of ackData[langCode]">
<td class="inner-guideline-content">{{ guideline }}</td>
</tr>
Expand Down Expand Up @@ -112,4 +118,4 @@
{{ 'acknowledgement.action_print' | translate }}
</button>
</div>
</div>
</div>
6 changes: 3 additions & 3 deletions pre-registration-ui/src/app/feature/summary/preview/preview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<mat-card-content [dir]="dataCaptureLangsDir[0]">
<div class="preview__body-content-container">
<div class="preview__body-content-div">
<table width="100%" aria-describedby="preview-data">
<table width="100%" aria-describedby="preview-data" role="presentation">
<tr *ngFor="let controlId of controlIds" class="row">
<td width="30%">
<span *ngFor="let dataCaptureLanguage of dataCaptureLanguages; let i = index; let first = first; let last = last;">
Expand Down Expand Up @@ -75,7 +75,7 @@
<mat-card-footer class="preview__footer-container">
<div class="preview__footer">
<div class="preview__file-container">
<table style="width:100%" *ngIf="documentMapObject" aria-describedby="preview-data">
<table style="width:100%" *ngIf="documentMapObject" aria-describedby="preview-data" role="presentation">
<tr class="preview__file__table__header">
<td *ngFor="let object of documentMapObject">{{ object.name }}</td>
</tr>
Expand All @@ -101,4 +101,4 @@
<button (click)="navigateNext()" class="user__btn" *ngIf="!appPrefetched">
{{ previewLabels.action_continue }}
</button>
</mat-card>
</mat-card>
2 changes: 1 addition & 1 deletion pre-registration-ui/src/assets/icons/iconfont/material-icons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}

.material-icons {
font-family: 'Material Icons';
font-family: 'Material Icons', sans-serif;
font-weight: normal;
font-style: normal;
font-size: 24px; /* Preferred icon size */
Expand Down
2 changes: 1 addition & 1 deletion pre-registration-ui/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ button {
}

.material-icons {
font-family: 'Material Icons';
font-family: 'Material Icons', sans-serif;
font-weight: normal;
font-style: normal;
font-size: 24px; /* Preferred icon size */
Expand Down
Loading