[MOSIP-27547] updated otp userid call (#1127)

* [MOSIP-27547] updated otp userid call Signed-off-by: Aiham Hasan <[email protected]> * [MOSIP-27547] updated otp userid call Signed-off-by: Aiham Hasan <[email protected]> * [MOSIP-27547] updated otp userid call Signed-off-by: Aiham Hasan <[email protected]> --------- Signed-off-by: Aiham Hasan <[email protected]>
mosip · Oct 26, 2023 · 9057874 · 9057874
1 parent d4c2e1d
commit 9057874
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/resident/resident-service/output.txt b/resident/resident-service/output.txt
@@ -0,0 +1 @@
+Sample PDF Content
diff --git a/resident/resident-service/src/main/java/io/mosip/resident/controller/ProxyOtpController.java b/resident/resident-service/src/main/java/io/mosip/resident/controller/ProxyOtpController.java
@@ -93,11 +93,10 @@ public ResponseEntity<MainResponseDTO<AuthNResponse>> sendOTP(
 			@Validated @RequestBody MainRequestDTO<OtpRequestDTOV2> userOtpRequest) throws ApisResourceAccessException, ResidentServiceCheckedException {
 		log.debug("ProxyOtpController::sendOTP()::entry");
 		ResponseEntity<MainResponseDTO<AuthNResponse>> responseEntity;
-		String userid = null;
+		String userid = userOtpRequest.getRequest().getUserId();
 		try {
 			IdentityDTO identityDTO = identityService.getIdentity(identityService.getResidentIndvidualIdFromSession());
 			requestValidator.validateProxySendOtpRequest(userOtpRequest, identityDTO);
-			userid = userOtpRequest.getRequest().getUserId();
 			responseEntity = proxyOtpService.sendOtp(userOtpRequest, identityDTO);
 		}
 		catch (InvalidInputException e) {
@@ -137,10 +136,9 @@ public ResponseEntity<MainResponseDTO<AuthNResponse>> sendOTP(
 	public ResponseEntity<MainResponseDTO<AuthNResponse>> validateWithUserIdOtp(
 			@Validated @RequestBody MainRequestDTO<OtpRequestDTOV3> userIdOtpRequest) {
 		log.debug("ProxyOtpController::validateWithUserIdOtp()::entry");
-		String userId = null;
+		String userId = userIdOtpRequest.getRequest().getUserId();
 		try {
 			requestValidator.validateUpdateDataRequest(userIdOtpRequest);
-			userId = userIdOtpRequest.getRequest().getUserId();
 		} catch (InvalidInputException e) {
 			audit.setAuditRequestDto(
 					EventEnum.getEventEnumWithValue(EventEnum.OTP_VALIDATION_FAILED, userId, "Validate OTP Failed"));