MOSIP-37784 Fixed name issue (#1360)

* MOSIP-37784 Fixed name issue

Signed-off-by: kameshsr <[email protected]>

* MOSIP-37784 Fixed name issue

Signed-off-by: kameshsr <[email protected]>

* MOSIP-37784 Fixed test case failure

Signed-off-by: kameshsr <[email protected]>

* MOSIP-37784 Fixed claims issue

Signed-off-by: kameshsr <[email protected]>

---------

Signed-off-by: kameshsr <[email protected]>

db_upgrade_scripts/mosip_resident/sql/1.2.1.0_to_1.2.1.1_rollback.sql

@@ -0,0 +1 @@
+\echo 'Upgrade Queries not required for transition from $CURRENT_VERSION to $UPGRADE_VERSION'

db_upgrade_scripts/mosip_resident/sql/1.2.1.0_to_1.2.1.1_upgrade.sql

@@ -0,0 +1 @@
+\echo 'Upgrade Queries not required for transition from $CURRENT_VERSION to $UPGRADE_VERSION'

resident/resident-service/src/main/java/io/mosip/resident/service/impl/IdentityServiceImpl.java

@@ -23,14 +23,14 @@
 import io.mosip.resident.validator.RequestValidator;
 import reactor.util.function.Tuple2;
 import reactor.util.function.Tuples;
+import io.mosip.resident.constant.RegistrationConstants;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.core.env.Environment;
 import org.springframework.security.core.context.SecurityContextHolder;
 import org.springframework.stereotype.Component;
 
-import javax.annotation.PostConstruct;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.time.LocalDate;
@@ -148,17 +148,17 @@ public IdentityDTO getIdentity(String id, boolean fetchFace, String langCode) th
 		return identityDTO;
 	}
 
-	public String getFullName(Map<String, Object> identity, String langCode) throws ResidentServiceCheckedException, IOException {
-		if(nameValueList==null){
-			nameValueList= getNameValueFromIdentityMapping();
+	public String getFullName(Map<String, Object> identity, String langCode)
+			throws ResidentServiceCheckedException, IOException {
+		if (nameValueList == null) {
+			nameValueList = getNameValueFromIdentityMapping();
 		}
-		StringBuilder nameValue = new StringBuilder();
-		for (String nameString : nameValueList) {
-			nameValue.append(getValueFromIdentityMapping(nameString, identity, langCode));
-		}
-		return String.valueOf(nameValue);
+		return nameValueList.stream()
+				.map(nameString -> getValueFromIdentityMapping(nameString, identity, langCode))
+				.collect(Collectors.joining(RegistrationConstants.SPACE));
 	}
 
+
 	private String getValueFromIdentityMapping(String nameString, Map<String, Object> identity, String langCode) {
 		if (nameString == null || identity == null || langCode == null) {
 			return ""; // Return early if any input is null
@@ -206,6 +206,7 @@ public List<String> getNameValueFromIdentityMapping() throws ResidentServiceChec
 		}
 		return nameValueList;
 	}
+
 
 	@Override
 	public Map<String, Object> getIdentityAttributes(String id, String schemaType) throws ResidentServiceCheckedException, IOException {

resident/resident-service/src/test/java/io/mosip/resident/controller/IdAuthControllerTest.java

@@ -2,8 +2,10 @@
 
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
+import java.io.IOException;
 import java.util.Map;
 
+import io.mosip.resident.exception.ResidentServiceCheckedException;
 import io.mosip.resident.util.Utility;
 import org.junit.Before;
 import org.junit.Test;
@@ -92,7 +94,7 @@ public class IdAuthControllerTest {
 	private RequestWrapper<IdAuthRequestDto> requestWrapper;
 
 	@Before
-	public void setUp() {
+	public void setUp() throws ResidentServiceCheckedException, IOException {
 		MockitoAnnotations.initMocks(this);
 		this.mockMvc = MockMvcBuilders.standaloneSetup(idAuthController).build();
 		requestWrapper = new RequestWrapper<IdAuthRequestDto>();