Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes #710

Merged
merged 4 commits into from
Jan 22, 2025
Merged

UI fixes #710

merged 4 commits into from
Jan 22, 2025

Conversation

traines-source
Copy link
Contributor

@traines-source traines-source commented Jan 21, 2025

  • this resolves, if we agree that checking GTFS-provided colors for sufficient contrast is not in scope rn, WebUI contrast issue: white text on white line badge not visible #708
  • this does very ugly things to at least temporarily fix the effect of accidentally tapping on the Departure/Arrival buttons or the date field when selecting a result from the From/To autocompletes. This is probably sth that needs fixing upstream in bits-ui, but I didn't yet manage to isolate the issue and spent far too much time on this already...

Lmk if you think that it makes sense to backport the changes from #705 and this PR to prima-mobile (since I still don't see any nice, straightforward way to share the components...)

@traines-source traines-source marked this pull request as draft January 21, 2025 23:50
@traines-source traines-source marked this pull request as ready for review January 21, 2025 23:56
@felixguendling
Copy link
Member

checking GTFS-provided colors for sufficient contrast

Yes, that's out of scope. I would prefer if checks for this were added to GTFS validator tools. This is nothing we should try to fix in MOTIS or the UI as we're too late in the pipeline.

upstream in bits-ui, but I didn't yet manage to isolate the issue and spent far too much time on this already.

If it's easier to just roll our own components in some cases, it's fine to kick out bits-ui. It just comes in handy if it's exactly matching the use case. If it's not, it can become a burden instead of helping us.

Lmk if you think that it makes sense to backport the changes from #705 and this PR to prima-mobile (since I still don't see any nice, straightforward way to share the components...)

That would be amazing! :)

@felixguendling felixguendling merged commit 6a00abe into motis-project:master Jan 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants