Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Via search fixes #158

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Via search fixes #158

merged 3 commits into from
Dec 9, 2024

Conversation

pablohoch
Copy link
Member

@pablohoch pablohoch commented Dec 5, 2024

Fixes the following bugs in the via search implementation that caused reconstruction errors:

  • If a trip passing a via stop has in/out allowed = false at the via stop, reconstructing the journey failed.
  • Queries where the last via stop is also a destination and has a non-zero stay duration were not handled properly. They are now handled as follows:
    • Intermodal destination (probably the only useful case): Stay duration at the last stop is added as waiting time between the arrival + start of the intermodal footpath. Transfer time at the last stop is ignored.
    • Station destination: Stay duration at the last stop is ignored (i.e. same result as if stay = 0 in the query). The stay duration can't be properly represented in the output journey in this case, but this doesn't seem like a useful case anyway.

@felixguendling felixguendling merged commit 0568714 into master Dec 9, 2024
10 checks passed
@felixguendling
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants