Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffered area polygon for extended visibility graphs #66

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

pablohoch
Copy link
Member

@pablohoch pablohoch commented Mar 7, 2024

Fixes an issue with area routing if start and/or destination points are close to an area.

When a segment (in the example: the segment between the two points where the red linestring crosses the platform area) is on the outer polygon of the area, the visibility check sometimes didn't work, resulting in crazy routes through the area.

To fix this, we now use a buffer of the outer polygon for visibility checks when extending the visibility graph.

Before:
chrome_2024-03-07_16-29-31

After:
chrome_2024-03-07_16-29-40

(Only the gray platform is an area in this example.)

The same problem occured with inner polygons:

Before:
chrome_2024-03-07_17-12-01

After:
chrome_2024-03-07_17-12-30

@pablohoch pablohoch changed the title Use buffered outer area polygon for extended visibility graphs Use buffered area polygon for extended visibility graphs Mar 7, 2024
@pablohoch pablohoch merged commit b469be8 into master Mar 7, 2024
12 checks passed
@pablohoch pablohoch deleted the extended-vg-buffer branch March 7, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant