Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1930782 - show_bug.cgi is using subframe scrolling again #2365

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kyoshino
Copy link
Collaborator

@kyoshino kyoshino commented Nov 26, 2024

Bug 1930782 - show_bug.cgi is using subframe scrolling again

Rework the fixed header implemented in #2334 not to use subframes. The challenges are the private bug banner pushing down the main content and some z-index issues, but I have used CSS variables and :has() to solve the problems.

And there is one test failure due to the sticky blue New Changes link... I have added a workaround to the Selenium tests.

@dklawren dklawren merged commit a814808 into mozilla-bteam:master Nov 26, 2024
17 checks passed
@kyoshino kyoshino deleted the 1930782-fixed-header branch November 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants