Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for classifying invalid compatibility reports to the http service #3846

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Nov 23, 2023

Fixes #3839

@ksy36
Copy link
Contributor Author

ksy36 commented Nov 23, 2023

r? @suhaibmujahid @marco-c

suhaibmujahid
suhaibmujahid previously approved these changes Nov 26, 2023
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

http_service/bugbug_http/app.py Outdated Show resolved Hide resolved
marco-c
marco-c previously approved these changes Nov 28, 2023
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If we get too many, we might want to have a separate queue with a lower priority so that we don't impact the other API endpoints too much. Let's see how it looks after deployment.

@ksy36 ksy36 dismissed stale reviews from marco-c and suhaibmujahid via 8bb9842 November 28, 2023 10:06
@ksy36
Copy link
Contributor Author

ksy36 commented Nov 28, 2023

LGTM! If we get too many, we might want to have a separate queue with a lower priority so that we don't impact the other API endpoints too much. Let's see how it looks after deployment.

Sounds good. We've shipped the reporter in Nightly on desktop about a week ago and got about 150 reports so far (only 80 have description and would have needed classification). But I think most of these reports are from QA testing the feature :)

@suhaibmujahid suhaibmujahid merged commit bb54c09 into mozilla:master Nov 29, 2023
6 checks passed
@ksy36 ksy36 deleted the issues/3839/1 branch November 29, 2023 19:21
@ksy36
Copy link
Contributor Author

ksy36 commented Nov 29, 2023

Thanks!

@marco-c
Copy link
Collaborator

marco-c commented Nov 29, 2023

@ksy36 when would you like to see this deployed?

@ksy36
Copy link
Contributor Author

ksy36 commented Nov 30, 2023

@ksy36 when would you like to see this deployed?

Would it be possible to deploy this some time next week? (I was thinking to start working on an ETL script that will use this endpoint then)

@marco-c
Copy link
Collaborator

marco-c commented Nov 30, 2023

Sure! I will deploy a new version now, so we can root out any potential bugs now and retrigger a new release if necessary.

@ksy36
Copy link
Contributor Author

ksy36 commented Nov 30, 2023

Perfect, thank you!

@marco-c
Copy link
Collaborator

marco-c commented Nov 30, 2023

I released a new version and triggered a new pipeline run: https://community-tc.services.mozilla.com/tasks/groups/NSVaUXIURx6zKSUcsItQZw. In a few hours, the new API endpoint should be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for classifying invalid compatibility reports to the http service
3 participants