Use the waitForUnselectedEditor integration test helper function more
#19290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies the `waitForUnselectedEditor` helper function to the remaining places, that most likely predate the introduction of the helper function, to deduplicate the code and to have a unified way of checking if a given editor is unselected.
timvandermeij
force-pushed
the
integration-tests-use-waitforunselectededitor
branch
from
ea2c68e to
5126210
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bf85feb34b7a9c9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/eb79cd9e80d4a0e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bf85feb34b7a9c9/output.txt Total script time: 9.59 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/eb79cd9e80d4a0e/output.txt Total script time: 23.50 mins
|
timvandermeij
deleted the
integration-tests-use-waitforunselectededitor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies the
waitForUnselectedEditorhelper function to the remaining places, that most likely predate the introduction of the helper function, to deduplicate the code and to have a unified way of checking if a given editor is unselected.Fixes a part of #19065.