Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify test code #1483

Closed
wants to merge 2 commits into from
Closed

simplify test code #1483

wants to merge 2 commits into from

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Jun 6, 2024

No description provided.

@rbri rbri marked this pull request as draft June 6, 2024 17:45
@gbrail
Copy link
Collaborator

gbrail commented Jun 7, 2024

Hey -- this looks good, but it will need to be merged one way or another with #1479, which is the PR that reorganizes the codebase -- as part of that, I moved some of the test cases so that some can be in the modules that they are associated with, rather than having all the tests in a separate module.

Assuming that the reorganization PR is going to happen, what makes sense for you? I could either:

  1. Ask you to rebase this PR against the branch in Reorganize the entire source code tree into modern Java modules #1479 and see if you can make it work -- it will require some work on your part at first but I hope that after that it's easier
  2. Or, I can merge Reorganize the entire source code tree into modern Java modules #1479 with the rest of the codebase first this weekend and then you can rebase on top of that
  3. Or, I can abandon that change, but I have been working with it for a while and I think it's better.

@rbri
Copy link
Collaborator Author

rbri commented Jun 8, 2024

@gbrail this is still work in progress, will rebase if i'm ready

@rbri rbri mentioned this pull request Jun 14, 2024
@rbri rbri closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants