improved date localization #1491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rbri
commented
Jun 15, 2024
rbri
commented
- use DateTimeFormatter instead of SimpleDateFormat
- Date.prototype.toLocaleString now handles locales argument
- make the formatter use Context.timezone instead of system default
- ES6: use FormatStyle.SHORT for the formatter to make it behave more like real browsers when Intl.DateTimeFormat is not supported
rbri
force-pushed
the
improved_date_localization
branch
from
eea19f2 to
3a4f05b
Compare
- Date.prototype.toLocaleString now handles locales argument - make the formatter use Context.timezone instead of system default - ES6: use FormatStyle.SHORT for the formatter to make it behave more like real browsers when Intl.DateTimeFormat is not supported
rbri
force-pushed
the
improved_date_localization
branch
from
3a4f05b to
13ec3f4
Compare
rbri
added a commit
to HtmlUnit/htmlunit-rhino-fork
that referenced
this pull request
Jun 16, 2024
|
@rbri any idea why the Java 21 test is failing? FWIW if you rebase then the GitHub action will upload the reports again and we'll see what happened... |
|
made some git mistakes on my side - #1535 is the new version of this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.