Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of test262 #1540

Closed
wants to merge 2 commits into from

Conversation

p-bakker
Copy link
Collaborator

@p-bakker p-bakker commented Jul 28, 2024

Worked with the maintainers of test262 to eliminate anything in the harness that prevented us from running the latest version of test262, so now we can be on the latest version

A next step will be to:

  • automatically add missing directories, if any, when running with the -DupdateTest262properties flag
  • maybe create a GitLab CI Action that automatically create a PR to updates the revision of test262 that is used by the /tests/test22 submodule?

But I think this can be merged as is

@p-bakker p-bakker marked this pull request as ready for review July 28, 2024 15:38
@p-bakker p-bakker marked this pull request as draft July 28, 2024 15:46
@p-bakker p-bakker force-pushed the updateTest262 branch 2 times, most recently from 4134d4a to c29b659 Compare July 29, 2024 06:55
@p-bakker
Copy link
Collaborator Author

p-bakker commented Jul 29, 2024

@gbrail The pipeline(s) for this PR failed (at some point), but the reason why cannot be deducted from the log: https://github.com/mozilla/rhino/actions/runs/10139556248/job/28033071384?pr=1540

It seems like there might be more info available given the message There were failing tests. See the report at: file:///home/runner/work/rhino/rhino/tests/build/reports/tests/test/index.html, but this file isn't uploaded as a result.

Is that something that can be done? Having a hard time now figuring out why the pipeline fails

@p-bakker p-bakker added test262 harness Issues related to failing test262 tests, due to Rhino not yet support certain JS features test262 Issues related to passage of test262 TestSuite labels Jul 29, 2024
@p-bakker p-bakker force-pushed the updateTest262 branch 2 times, most recently from 92f000d to 8fc2783 Compare July 30, 2024 20:04
@p-bakker p-bakker marked this pull request as ready for review July 30, 2024 20:05
@gbrail
Copy link
Collaborator

gbrail commented Aug 8, 2024

This is great! And it works for me and it looks like you figured out the problem with the automated tests.

I want to get rid of the Jacoco warning that pops up, so I'm going to merge this manually along with a fix for that as well.

Thanks!

@gbrail
Copy link
Collaborator

gbrail commented Aug 8, 2024

Thanks -- merged manually.

@gbrail gbrail closed this Aug 8, 2024
@gbrail
Copy link
Collaborator

gbrail commented Aug 8, 2024

Just wanted to remind everyone to run "git submodule update" after they pull from GH because otherwise you may not have the version of the test262 tests that you should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test262 harness Issues related to failing test262 tests, due to Rhino not yet support certain JS features test262 Issues related to passage of test262 TestSuite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants