fix: Make AVCaptureDevice.sensorOrientation safer (#3064)

mrousavy · Jul 10, 2024 · 9a09260 · 9a09260
1 parent a8ba80d
commit 9a09260
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/package/ios/Core/Extensions/AVCaptureDevice+sensorOrientation.swift b/package/ios/Core/Extensions/AVCaptureDevice+sensorOrientation.swift
@@ -23,20 +23,28 @@ extension AVCaptureDevice {
 
     // 1. Create a capture session
     let session = AVCaptureSession()
-    session.sessionPreset = .low
+    if session.canSetSessionPreset(.low) {
+      session.sessionPreset = .low
+    }
 
     // 2. Add this device as an input
     guard let input = try? AVCaptureDeviceInput(device: self) else {
       VisionLogger.log(level: .error, message: "Cannot dynamically determine \(uniqueID)'s sensorOrientation, " +
         "falling back to \(DEFAULT_SENSOR_ORIENTATION)...")
       return DEFAULT_SENSOR_ORIENTATION
     }
+    guard session.canAddInput(input) else {
+      return DEFAULT_SENSOR_ORIENTATION
+    }
     session.addInput(input)
 
     // 3. Add an output (e.g. video data output)
     let output = AVCaptureVideoDataOutput()
     output.automaticallyConfiguresOutputBufferDimensions = false
     output.deliversPreviewSizedOutputBuffers = true
+    guard session.canAddOutput(output) else {
+      return DEFAULT_SENSOR_ORIENTATION
+    }
     session.addOutput(output)
 
     // 4. Inspect the default orientation of the output