-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Drawer] Deprecate composed classes #44870
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
085151b
to
846dfdc
Compare
I observed that but the docs mention that it uses Question to maintainers - |
|
ccebcdd
to
f5f74da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @yash49, great work! Sorry for the delay.
About 1. and 2. about the classes, they were incorrectly documented. You're correct, the documentation should mention MuiDrawer
, not MuiSwipeableDrawer
. I pushed a commit to fix this.
- Do we need any tests for new
MuiDrawer-anchor<Direction>
classes?
Yes, please! 😊
May I also ask you to prepare a sandbox (You can use this one which uses this PR builds) testing that the deprecated classes are correctly replaced by the suggested compositions? For example:
In the sandbox, have two drawers, one with:
<Drawer
sx={[`&.${drawerClasses.paperAnchorBottom}`]: {
backgroundColor: 'red',
}
/>
and another with:
<Drawer
sx={[`&.${drawerClasses.anchorBottom} > .${drawerClasses.paper}`]: {
backgroundColor: 'red',
}
/>
And the result should be the same.
No need to do it with all the combinations, these should be enough:
paperAnchorBottom
paperAnchorDockedBottom
part of #41282
migration guide preview - https://deploy-preview-44870--material-ui.netlify.app/material-ui/migration/migrating-from-deprecated-apis/#drawer
docs preview - https://deploy-preview-44870--material-ui.netlify.app/material-ui/api/drawer/#classes