Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix demo rendering issue on Codesandbox #16118

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Jan 9, 2025

https://mui.com/x/react-data-grid/api-object/#outside-the-data-grid does not render on Codesanbox.

Found out that the reason is missing pageSize in pageSizeOptions.

pageSizeOptions default is [25, 50, 100]. I have searched in other demos for the paginationModel, setPaginationModel state getter/setter and found that all other demos either have pageSize: 25 or they add their pageSizeOptions values.

I have extended the default with the pageSize that was in the code.

Preview
https://deploy-preview-16118--material-ui-x.netlify.app/x/react-data-grid/api-object/#outside-the-data-grid

@arminmeh arminmeh added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jan 9, 2025
@arminmeh arminmeh requested a review from a team January 9, 2025 20:10
@mui-bot
Copy link

mui-bot commented Jan 9, 2025

Deploy preview: https://deploy-preview-16118--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against cdc7ee5

@arminmeh arminmeh added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Jan 10, 2025
@arminmeh arminmeh merged commit d25c213 into mui:master Jan 10, 2025
26 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants