Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve release #4573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] Improve release #4573

wants to merge 1 commit into from
+10 −3

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Dec 30, 2024
Janpot
Janpot reviewed Jan 7, 2025
View reviewed changes
packages/toolpad-core/package.json
@@ -38,7 +38,7 @@
},
"homepage": "https://github.com/mui/toolpad#readme",
"scripts": {
"clean": "rimraf build",
"clean": "rimraf --glob build \"*.tsbuildinfo\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes in this PR feel like they're at conflict with each other. Either we generate tsbuildinfo files in the build folder and then the old clean command would suffice. Or we generate them outside of the build folder and then we don't remove them during the copy script. But maybe there are reasons to keep this? I know there are differences in build between studio packages and core packages.

Janpot
Janpot approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @Janpot @bharatkashyap