Added the telegram notifier #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Apr 24, 2024
iulianpascalau
commented
- added the telegram notifier
notifiers/telegramNotifier.go
Outdated
|
|
||
| // OutputMessages will push the provided messages as error | ||
| func (notifier *telegramNotifier) OutputMessages(messages ...core.OutputMessage) { | ||
| log.Debug("notifier.OutputMessages sending telegram notification", "num messages", len(messages)) |
There was a problem hiding this comment.
In other places, the log message contained the name of the actual struct. E.g. here it would be telegramNotifier.OutputMessages.
There was a problem hiding this comment.
refactored all log messages
notifiers/telegramNotifier_test.go
Outdated
| expectedTitle string, | ||
| numCalls *uint32, | ||
| ) *httptest.Server { | ||
| response := &pushoverResponse{ |
There was a problem hiding this comment.
This response object is specific to pushover. Maybe use one for TG?
There was a problem hiding this comment.
copy-paste error. Removed
miiu96
previously approved these changes
Apr 25, 2024
andreibancioiu
approved these changes
Apr 30, 2024
miiu96
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.