Docker-related fixes && typo fix #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Docker README corrections
Fix: Config.toml typo
Fix: Added some missing labels
Dockerfile
Outdated
| @@ -13,6 +13,9 @@ RUN apt-get update && apt-get upgrade && apt-get install -y ${PACKAGES} | |||
| RUN adduser --uid ${UID} ${USERNAME} | |||
|
|
|||
| FROM scratch AS runner | |||
| LABEL description="This Docker image runs the MultiversX monitoring binary." | |||
| LABEL website="https://multiversx.com/" | |||
| LABEL maintainer="Virgil GAGNIEUX <[email protected]>" | |||
There was a problem hiding this comment.
Since you are the third that changes the code or installation support files, I think this will be better changed to:
LABEL maintainer="MultiversX Validators Community <https://t.me/MultiversXValidators>"
iulianpascalau
approved these changes
May 31, 2024
miiu96
approved these changes
May 31, 2024
|
Thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the “troobleshout” section of the README file.
Fixed write error in “Config.toml” file.
Added labels to Docker image.
Don't hesitate to give me feedback