Support for new endpoint /node/waiting-epochs-left/:key #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
reviewed
Nov 17, 2023
process/nodeGroupProcessor.go
Outdated
Comment on lines
246
to
248
| func (ngp *NodeGroupProcessor) GetWaitingEpochsLeftForPublicKey(publicKey string) (*data.WaitingEpochsLeftApiResponse, error) { | ||
| observers, err := ngp.proc.GetAllObservers() | ||
| if err != nil { |
There was a problem hiding this comment.
check for nil/empty publicKey before trying to get all observers?
sasurobert
previously approved these changes
Nov 20, 2023
iulianpascalau
previously approved these changes
Nov 20, 2023
ssd04
previously approved these changes
Nov 20, 2023
sasurobert
previously approved these changes
Nov 20, 2023
sstanculeanu
dismissed stale reviews from sasurobert, ssd04, and iulianpascalau
via
f6dea6f
iulianpascalau
approved these changes
Nov 21, 2023
sasurobert
approved these changes
Nov 21, 2023
ssd04
approved these changes
Nov 21, 2023
gabi-vuls
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.