Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos: Require EOS 4.23+ #2015

Merged
merged 6 commits into from
Oct 20, 2023
Merged

eos: Require EOS 4.23+ #2015

merged 6 commits into from
Oct 20, 2023

Conversation

bewing
Copy link
Member

@bewing bewing commented Oct 16, 2023

No description provided.

bewing added 6 commits October 11, 2023 15:09
@bewing
eos: add explicit minimum version check
392e5e8 
Require 4.23.0F or later EOS image
Require pyeapi >= 1.0.2 resolves #1958
Remove all references to FN0039 and any configuration alterations
Remove text-based VRF parsing in favor of JSON version
Update all tests to reflect
@bewing
eos: update get_environment commands and tests
5de951d 
Use new-format "show system ..." command for environment
Update to also detect cEOS systems not having power supplies
@bewing
eos: update bgp getters for new syntax
cc2c310 
show ip bgp neigh -> show ip bgp peers
@bewing
eos: update get_snmp_information command syntax
75461b6 
show snmp -> show snmp v2-mib
@bewing
eos: update get_users commands
805f98f 
show user-accounts -> show users accounts
@bewing
eos: add optional real-device integration test
9c09afe
@bewing bewing self-assigned this Oct 16, 2023
ktbyers
ktbyers approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ktbyers ktbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktbyers
Copy link
Contributor

ktbyers commented Oct 18, 2023

@bewing Good job.

We should probably roll the NAPALM major version when we release this--since it is a pretty big change. What do you think?

@bewing
Copy link
Member Author

bewing commented Oct 18, 2023

We should probably roll the NAPALM major version when we release this--since it is a pretty big change. What do you think?

Agreed. Do we need to hold merging this until we think we're ready for a major release? I am in no particular rush.

@ktbyers
Copy link
Contributor

ktbyers commented Oct 18, 2023

@bewing Naaah, we should merge it and then next release will be a major release.

@bewing bewing merged commit cca35cf into develop Oct 20, 2023
12 checks passed
@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
@mirceaulinic mirceaulinic deleted the eos-423plus branch April 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbyers ktbyers ktbyers approved these changes

@mirceaulinic mirceaulinic Awaiting requested review from mirceaulinic

Assignees

@bewing bewing

Labels
eos fn0039
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bewing @ktbyers @mirceaulinic