Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-2809 eslint #5652

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

WV-2809 eslint #5652

wants to merge 4 commits into from

Conversation

PatchesMaps
Copy link
Contributor

Description

Our .eslintrc file has a lot of overrides. These should be turned back on and addressed. In this ticket, address these rules & re-enable this rule moving forward.

jsx-a11y/anchor-has-content
jsx-a11y/control-has-associated-label
jsx-a11y/no-noninteractive-tabindex
jsx-a11y/label-has-associated-control
jsx-a11y/mouse-events-have-key-events
jsx-a11y/no-noninteractive-element-interactions
jsx-a11y/alt-text
jsx-a11y/anchor-is-valid

How To Test

  1. git checkout WV-2809-eslint
  2. npm i && npm run watch
  3. Navigate to this link
  4. Make sure that all of the effected components look and behave normally.

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants