Shutdown subscription_executor on close and reconnect
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankiru
force-pushed
the
evl/issue-153
branch
4 times, most recently
from
2b32655 to
431b6cc
Compare
vankiru
force-pushed
the
evl/issue-153
branch
from
431b6cc to
2d82317
Compare
vankiru
force-pushed
the
evl/issue-153
branch
from
f727700 to
91de54c
Compare
palkan
requested review from
palkan and
wallyqs
and removed request for
palkan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #153.
Close connection
On close connection, we shut down
subscription_executorand give subscriptionsoptions[:close_timeout](30 seconds by default) to finish their work with the NATS server. After that, we proceed with the rest of the logic.Reconnect
On reconnection, we shut down
subscriprion_executorby initiating an orderly termination of all in-progress tasks but do not wait for them to finish. After the threads finish their work, they will be automatically closed in the background.