Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RuboCop #157

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Introduce RuboCop #157

merged 2 commits into from
Jan 10, 2025

Conversation

palkan
Copy link
Collaborator

@palkan palkan commented Jan 8, 2025

This is a follow-up for #154.

Only Mostly cosmetic changes (and RuboCop enforcement) + some flaky specs fixes.

@palkan palkan requested a review from wallyqs January 8, 2025 20:56
@palkan palkan force-pushed the evl/housekeeping-2-rubocop branch from ce29b7e to 1ca1842 Compare January 8, 2025 23:44
@palkan palkan force-pushed the evl/housekeeping-2-rubocop branch from 1ca1842 to ffd6218 Compare January 9, 2025 00:47
@palkan
Copy link
Collaborator Author

palkan commented Jan 9, 2025

Hey @wallyqs! Could you please take a look?

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 02673a4 into main Jan 10, 2025
14 checks passed
@wallyqs wallyqs deleted the evl/housekeeping-2-rubocop branch January 10, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants