Add Client#reconnect #159
Open
Add Client#reconnect #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Jan 17, 2025
| @@ -270,6 +270,19 @@ def connect(uri = nil, opts = {}) | |||
| self | |||
| end | |||
|
|
|||
| def reconnect | |||
There was a problem hiding this comment.
let's call it force_reconnect like the Go client, there will likely be a more graceful reconnect in the future https://github.com/nats-io/nats.go/blob/4732ef6eefb7385904bbe0136bf0b93e82cc5270/nats.go#L2197-L2204
wallyqs
reviewed
Jan 17, 2025
| nats.close | ||
| end | ||
|
|
||
| it "resumes subscribtions work" do |
There was a problem hiding this comment.
Suggested change
| it "resumes subscribtions work" do | |
| it "resumes subscriptions work" do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements
Client#reconnectmethod: Add reconnect method.Notes for the
reconnectmethod:NATS::IO::ConnectionClosedErrorif a connection is closed, disconnected, or draining.