Add version info to the packages name #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's much more that needs doing for this to work, the self-update is looking for the versions in a specific way, so the change of the tag may create an issue here or there. |
|
@wallyqs can you take a look if we can simply just change the tag and not break the self-update (up or down. |
|
I think this is a good change, not sure about self update we will have to update these for the install for example as well: https://github.com/ConnectEverything/client-tools/blob/main/synadia-nats-channels.conf#L17-L37 |
|
not 100% sure but the package |
|
We just started supporting tagged versions for Go modules, so we can look into supporting this for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add version information in the packages' name
nsc-linux-amd64.zip-->nsc-2.6.1-linux-amd64.zipCloses: #471