Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Murphy tutorial #129

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Review of Murphy tutorial #129

merged 9 commits into from
Feb 14, 2024

Conversation

DerynGriffiths
Copy link
Collaborator

@DerynGriffiths DerynGriffiths commented Dec 15, 2023

For consideration and discussion re the Murphy Diagrams tutorial.

@DerynGriffiths DerynGriffiths marked this pull request as draft December 15, 2023 04:28
@nicholasloveday nicholasloveday marked this pull request as ready for review December 17, 2023 22:26
@nicholasloveday
Copy link
Collaborator

@tennlee I have updated this pull request based on the suggestions from @DerynGriffiths

@DerynGriffiths
Copy link
Collaborator Author

@nicholasloveday , @tennlee I had another look at this and added one missing space. I think it is good to go.

Same trouble as MAE with the display of the help notes - do we have a solution?
I like the restructure which puts some of the more advanced background material at the end of the notebook.

@nicholasloveday
Copy link
Collaborator

@nicholasloveday , @tennlee I had another look at this and added one missing space. I think it is good to go.

Same trouble as MAE with the display of the help notes - do we have a solution? I like the restructure which puts some of the more advanced background material at the end of the notebook.

@DerynGriffiths - I have saved the notebook with all cells executed apart from the "help" ones. https://github.com/nci/scores/blob/afe7ae1f9e3d6ad5320995b98a1a4703f535207e/tutorials/Murphy_Diagrams.ipynb

DerynGriffiths and others added 8 commits February 14, 2024 10:23
* First review and extension

* Round 2 for MAE tutorial following verbal feedback from Tennessee

* Slightly modify the tutorial so that the help message is not shown by default,
but it is easy to access if wanted

---------

Co-authored-by: Tennessee Leeuwenburg <[email protected]>
Signed-off-by: tennlee <[email protected]>
* feat: add proportion exceeding wrapper for flip flop index
* minor updates to flipflop proportion exceeding

---------

Co-authored-by: Nicholas Loveday <[email protected]>
* Split first cell into two
* Added a semi-colon to a markdown cell
* Removed one unused variable
@tennlee tennlee merged commit 1239659 into develop Feb 14, 2024
6 checks passed
@tennlee tennlee deleted the murphyTutorial branch February 14, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants