-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of Murphy tutorial #129
Conversation
@tennlee I have updated this pull request based on the suggestions from @DerynGriffiths |
@nicholasloveday , @tennlee I had another look at this and added one missing space. I think it is good to go. Same trouble as MAE with the display of the help notes - do we have a solution? |
a5bf769
to
afe7ae1
Compare
@DerynGriffiths - I have saved the notebook with all cells executed apart from the "help" ones. https://github.com/nci/scores/blob/afe7ae1f9e3d6ad5320995b98a1a4703f535207e/tutorials/Murphy_Diagrams.ipynb |
* First review and extension * Round 2 for MAE tutorial following verbal feedback from Tennessee * Slightly modify the tutorial so that the help message is not shown by default, but it is easy to access if wanted --------- Co-authored-by: Tennessee Leeuwenburg <[email protected]>
Signed-off-by: tennlee <[email protected]>
* feat: add proportion exceeding wrapper for flip flop index * minor updates to flipflop proportion exceeding --------- Co-authored-by: Nicholas Loveday <[email protected]>
* Split first cell into two * Added a semi-colon to a markdown cell * Removed one unused variable
For consideration and discussion re the Murphy Diagrams tutorial.