-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically exec js commands #366
Conversation
@frol this is ready for a second review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gagdiez I noticed a minor bug with call
(and probably view
) command:
In JS CLI it was totally fine to skip arguments. Let's use text-args
instead of json-args
OR pass {}
instead of an empty string to json-args
.
@frol fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 8
@gagdiez Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 8 @gagdiez check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
🌟 Score recorded!@frol, thank you for scoring this pull request in the Race of Sloths! |
## 🤖 New release * `near-cli-rs`: 0.12.0 -> 0.13.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.13.0](v0.12.0...v0.13.0) - 2024-07-30 ### Added - Automatically exec legacy JS CLI commands for full backward compatibility ([#366](#366)) - Added the ability to use the TEACH-ME mode ([#360](#360)) - Added a new subcommand to edit configuration parameters ([#367](#367)) ### Fixed - Fixed the fallback implementation of fetching active staking pools ([#369](#369)) ### Other - Fixed typos in user prompts and the guide ([#372](#372)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
✅ PR is finalized!Your contribution is much appreciated with a final score of 8! |
This PR tries to automatically execute the CLI commands that are suggested after somebody tries to run a JS commands.
I will put is as a draft for now, since my initially proposed code might be very wrong.
If the core devs feel it would be faster for them to code this instead of reviewing my code, please feel free to close this PR.
@race-of-sloths