refactor log4j-core-test to junit 5 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
ninetteadhikari
changed the title
ninetteadhikari
force-pushed
the
refactor-log4j-core-test1
branch
4 times, most recently
from
6422755 to
12a1600
Compare
ninetteadhikari
force-pushed
the
refactor-log4j-core-test1
branch
3 times, most recently
from
f2ff08f to
d18b772
Compare
ninetteadhikari
changed the title
log4j-core-test/src/test/java/org/apache/logging/log4j/MarkerMixInTest.java
Show resolved
Hide resolved
log4j-core-test/src/test/java/org/apache/logging/log4j/core/Log4j1222Test.java
Show resolved
Hide resolved
| @@ -53,6 +52,6 @@ public void testFlushAtEndOfBatch() throws Exception { | |||
| reader.close(); | |||
| file.delete(); | |||
| assertNotNull("line1", line1); | |||
There was a problem hiding this comment.
Does this need to change the order? Not sure
There was a problem hiding this comment.
oops you are right! i wonder how it passed the tests.. 🤔
| @@ -65,9 +64,9 @@ public void testAsyncLogWritesToLog() throws Exception { | |||
| reader.close(); | |||
| file.delete(); | |||
| assertNotNull("line1", line1); | |||
There was a problem hiding this comment.
Does this need to change the order?
ninetteadhikari
force-pushed
the
refactor-log4j-core-test1
branch
3 times, most recently
from
39f6585 to
feafaee
Compare
Signed-off-by: Ninette Adhikari <[email protected]>
Signed-off-by: Ninette Adhikari <[email protected]>
Signed-off-by: Ninette Adhikari <[email protected]>
ninetteadhikari
force-pushed
the
refactor-log4j-core-test1
branch
from
9412b17 to
4b3bfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed
Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located inxto JUnit5.cPlease note the
log4j-core-testmodule contains over 150 files and this PR updates the tests for 40 of them. Further PRs will be made to update the rest of the tests.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory